-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/power scale changes for resiliency #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randeepdell
requested review from
bpjain2004,
meggm,
nitesh3108,
prablr79,
Sakshi-dell and
shefali-malhotra
as code owners
May 4, 2022 10:01
meggm
previously approved these changes
May 4, 2022
meggm
reviewed
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some checks are failing
Resolved. |
…ithub.com/dell/csi-powerscale into feature/powerScale-changes-for-resiliency
randeepdell
commented
May 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need reviewers to take a look at it.
meggm
approved these changes
May 16, 2022
prablr79
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables resiliency for csi-powerscale driver.
Below are the changes.
common/constants/consts.go - added default values
common/constants/envvars.go - added env variable constants
helm/csi-isilon/values.yaml - specifies API port and arrayConnectivityPollRate
helm/csi-isilon/templates/controller.yaml - read the arrayConnectivityPollRate specified in podmon
helm/csi-isilon/templates/node.yaml - read the arrayConnectivityPollRate specified in podmon
As there is no Isilon platform support to test connecitivity, the below files poll the array from the k8s node and expose an API to test the connecitivity using probes.
service/controllerNodeToArrayConnectivity.go - forms the url and queries worker node for connecitity to array
service/nodeConnectivityChecker.go - periodically runs probe and returns the status when API is called.
service/service.go - starts the API connecitivity check
service/csi_extension_server.go - implements csi extension to enable podmon
service/isiService.go - calls API using gopowerscale lib to fetch active clients running IOs
GitHub Issues
dell/csm#262
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration