Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podmon helmchart commits #75

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Podmon helmchart commits #75

merged 3 commits into from
Apr 18, 2022

Conversation

nitesh3108
Copy link
Collaborator

@nitesh3108 nitesh3108 commented Apr 13, 2022 •
edited
Loading

Description

Helm charts commits to enable support for podmon.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#262

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Have checked Driver installation/Uninstallation.

Sakshi-dell
Sakshi-dell approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@Sakshi-dell Sakshi-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanmydell
Copy link
Contributor

@nitesh3108 @randeepsharma : Do we have corresponding doc PR raised for the same?

@randeepdell randeepdell merged commit 6979a6c into main Apr 18, 2022
@randeepdell
Copy link
Contributor

@nitesh3108 @randeepsharma : Do we have corresponding doc PR raised for the same?

Not yet. We are still making changes, once those changes are IN, we will raise a doc PR simultaneously

@randeepdell randeepdell deleted the podmon-helmchart-commits branch April 18, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randeepdell randeepdell randeepdell approved these changes

@Sakshi-dell Sakshi-dell Sakshi-dell approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitesh3108 @shanmydell @randeepdell @Sakshi-dell