Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix- use the correct snapshot isipath #60

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

bpjain2004
Copy link
Collaborator

@bpjain2004 bpjain2004 commented Mar 3, 2022

Description

When RO volume is created from snapshot and if the isiPaths are different (new volume's isiPath and source volume's isiPath of snapshot) then it is resulting in failure. This PR fixed the issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
211

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Created RO volume from snapshot with different isiPaths successfully.
Created RW volumes from snapshot with different isiPaths successfully.
Successfully able to delete both the snapshot and new volumes without any issues

@bpjain2004 bpjain2004 merged commit 7f4c070 into main Mar 3, 2022
@bpjain2004 bpjain2004 deleted the bugfix/ro_vol_from_snapshot branch March 3, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants