Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go version update in go.mod and fsinfo used from gofsutils #49

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Go version update in go.mod and fsinfo used from gofsutils #49

merged 2 commits into from
Feb 3, 2022

Conversation

Sakshi-dell
Copy link
Collaborator

@Sakshi-dell Sakshi-dell commented Feb 2, 2022 •
edited by gallacher
Loading

Description

  1. Updated go version to 1.17 in go.mod
  2. used FsInfo from gofsutils instead of k8s

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#149

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@Sakshi-dell Sakshi-dell changed the title Golang version update and fsinfo used from gofsutils Go version update in go.mod and fsinfo used from gofsutils Feb 2, 2022
randeepdell
randeepdell approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@randeepdell randeepdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prablr79
prablr79 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional approval, hope all dependent lib is validated

@bpjain2004 bpjain2004 merged commit 0b7ce03 into main Feb 3, 2022
@bpjain2004 bpjain2004 deleted the Update-golang-version branch February 3, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpjain2004 bpjain2004 bpjain2004 left review comments

@randeepdell randeepdell randeepdell approved these changes

@prablr79 prablr79 prablr79 approved these changes

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sakshi-dell @prablr79 @bpjain2004 @randeepdell