KRV-2731 : Verification of secrets repeated twice while installation of driver via helm

[karthikk92]

Description

Verification of secrets repeated twice while installation of driver via helm

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#168

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• Backward compatibility is not broken

How Has This Been Tested?

[bpjain2004]

There is no repetition of secret object verification done from installer. There are two verifications- one for creds secret and another for optional cert secret. I agree that the log messages can be more descriptive. Please see the following

|- Verifying that required secrets have been created                Success
|
|- Verifying that optional secrets have been created                Success

Also, this PR is partial. With the current changes from PR you need to have following changes as well, if you want to consider cert secret as required secret and not optional one(I agree with this).

(root@bjain48)-(~/csi-powerscale/dell-csi-helm-installer) (main)
 -> git diff
diff --git a/dell-csi-helm-installer/verify-csi-isilon.sh b/dell-csi-helm-installer/verify-csi-isilon.sh
index 54ca00e..a1586a9 100644
--- a/dell-csi-helm-installer/verify-csi-isilon.sh
+++ b/dell-csi-helm-installer/verify-csi-isilon.sh
@@ -15,7 +15,7 @@ function verify-csi-isilon() {
   verify_openshift_versions "4.8" "4.9"
   verify_namespace "${NS}"
   verify_required_secrets "${RELEASE}-creds"
-  verify_optional_secrets "${RELEASE}-certs"
+  verify_required_secrets "${RELEASE}-certs-0"
   verify_alpha_snap_resources
   verify_snap_requirements
   verify_helm_3

[karthikk92]

closing since, method verify_optional_secrets is called, logs are not getting repeated. So this method call will have to take care only in csi-unity

Thanks