Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reverseDNS lookup mandate for nodeID #41

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

randeepdell
Copy link
Contributor

Description

CSI-PowerScale driver crashes when resolution of IP to FQDN fails , this is on environments where we don't have a reverse lookup IP record.
We could choose between nodename and IP. Have considered IP when IP resolution to FQDN fails.

GitHub Issues

dell/csm#142

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • [] I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed CSI-PowerScale with main branch changes and was able to create and delete storage class, PVC and pods.
  • Installed CSI-PowerScale driver with 2.1.0 version and create storage class, PVC and pods. Changed to main branch with the changes, installed the main branch build image and deleted the existing storage class, PVC and pods, which were successful.

@randeepdell randeepdell changed the title Remove-reverseDNS-lookup-for-nodeID Remove reverseDNS lookup mandate for nodeID Dec 22, 2021
@bpjain2004
Copy link
Collaborator

Changes look ok. Please add unit and integration tests where fqdn value in the input node id is the same as IP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants