Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ioutil package and update modules #207

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Remove deprecated ioutil package and update modules #207

merged 5 commits into from
Aug 16, 2023

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Aug 10, 2023 •
edited
Loading

Description

  • Remove deprecated ioutil package
  • Update go modules
  • Remove unwanted build stage in podman-build
  • Minor formatting error fixes

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885
dell/csm#916

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Run Sanity Test

Screenshot 2023-08-14 111849
Screenshot 2023-08-14 111909

@chimanjain chimanjain marked this pull request as ready for review August 14, 2023 05:57
@chimanjain chimanjain requested a review from nitesh3108 August 14, 2023 07:40
nitesh3108
nitesh3108 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@nitesh3108 nitesh3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HarishH-DELL
HarishH-DELL approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chimanjain chimanjain merged commit ea268af into main Aug 16, 2023
@chimanjain chimanjain deleted the refactor-code branch August 16, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chimanjain @nitesh3108 @HarishH-DELL