Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modules and basic changes for v2.8.0 release #204

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Update modules and basic changes for v2.8.0 release #204

merged 5 commits into from
Jul 24, 2023

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Jul 21, 2023 •
edited by shanmydell
Loading

Description

  • Basic changes for v2.8.0 release
  • Update modules.
  • remove unnecessary fmt.Printf
  • Name return parameters correctly.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Run unit-test
  • Run sanity test
    Screenshot 2023-07-18 182616

@chimanjain chimanjain self-assigned this Jul 21, 2023
@chimanjain chimanjain added the enhancement New feature or request label Jul 21, 2023
@chimanjain chimanjain changed the title Update CSI Spec and basic changes for v2.8.0 release Update modules and basic changes for v2.8.0 release Jul 21, 2023
@chimanjain chimanjain removed the enhancement New feature or request label Jul 21, 2023
HarishH-DELL
HarishH-DELL previously approved these changes Jul 21, 2023
View reviewed changes
@HarishH-DELL HarishH-DELL self-requested a review July 21, 2023 09:03
shefali-malhotra
shefali-malhotra approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chimanjain chimanjain merged commit 6417c41 into main Jul 24, 2023
@chimanjain chimanjain deleted the update-mod branch July 24, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

Assignees

@chimanjain chimanjain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chimanjain @shefali-malhotra @HarishH-DELL