Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code coverage improvement for isiService.go file #103

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

meggm
Copy link
Contributor

@meggm meggm commented Jul 7, 2022

Description

This PR is to enhance the code-coverage for isiService.go file in CSI-PowerScale repo. Target to reach is 80%
The function "GetExportsWithResume" is commented as this is used as part ListVolumesAPI which is also commented.
There is no other API which uses this function. Once the ListVolumes API is implemented then this function can be uncommented.

Existing coverage:
overall - 67.6%
isiService.go - 72.9%

With This PR:
overall - 68.7%
isiService.go - 80.5%

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#350

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Changes are done for unit test cases

  • Test A
  • Test B

@meggm meggm requested a review from randeepdell July 7, 2022 08:57
Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meggm meggm merged commit b7856a1 into main Jul 7, 2022
@randeepdell randeepdell deleted the code-coverage-isi branch September 8, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants