Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dirty bit #67

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Removing dirty bit #67

merged 1 commit into from
Mar 17, 2022

Conversation

delldubey
Copy link
Contributor

Description

It fixes the dirty bit in the driver image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#222

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Driver image build and driver logs

@delldubey delldubey changed the title Dockerfile changes Removing dirty bit Mar 17, 2022
boyamurthy
boyamurthy approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delldubey delldubey merged commit dbd9541 into main Mar 17, 2022
@delldubey delldubey mentioned this pull request Mar 17, 2022
Closed
@shanmydell shanmydell deleted the bug_222_removing_dirty_bit branch May 6, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@shanmydell shanmydell shanmydell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delldubey @shanmydell @boyamurthy