Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test and integration test for RWOP #54

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Unit test and integration test for RWOP #54

merged 2 commits into from
Feb 14, 2022

Conversation

mahesr2
Copy link
Contributor

@mahesr2 mahesr2 commented Feb 7, 2022

Description

Unit test and integration test for SINGLE_NODE_SINGLE_WRITER and SINGLE_NODE_MULTI_WRITER for kubernetes 1.22+

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#175

Checklist:

  • Have you run format, vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

boyamurthy
boyamurthy previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@mahesr2 mahesr2 force-pushed the feature_RWOP_Unit_test_cases branch from 723f8fc to 26a00e9 Compare February 11, 2022 07:28
boyamurthy
boyamurthy approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@shanmydell shanmydell merged commit 6674d60 into main Feb 14, 2022
@shanmydell shanmydell deleted the feature_RWOP_Unit_test_cases branch February 14, 2022 12:01
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@mahesr2 @Sahiba-Gupta
Unit test and integration test for RWOP (#54)
b4818b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@shanmydell shanmydell shanmydell approved these changes

@mjsdell mjsdell Awaiting requested review from mjsdell

@kumarrprashant2005 kumarrprashant2005 Awaiting requested review from kumarrprashant2005

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@delldubey delldubey Awaiting requested review from delldubey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahesr2 @shanmydell @boyamurthy