Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KRV-2731 : Verification of secrets repeated twice while installation of driver via helm #51

Closed
wants to merge 2 commits into from

Conversation

karthikk92
Copy link

Description

Verification of secrets repeated twice while installation of driver via helm

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#168

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

2

@karthikk92
Copy link
Author

closing since, method verify_optional_secrets is called, logs are not getting repeated. So this method call will have to take care only in csi-unity

Thanks

@karthikk92 karthikk92 closed this Feb 1, 2022
@boyamurthy boyamurthy deleted the heml_install_changes branch February 3, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant