Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Golang version to 1.17 #44

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Conversation

boyamurthy
Copy link
Contributor

Updating Golang version to 1.17 to have latest security fixes .

GitHub Issue #
dell/csm#149

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

@shanmydell
Copy link
Collaborator

@boyamurthy go: golang.org/x/[email protected] requires
golang.org/x/[email protected]: missing go.sum entry; to add it:
go mod download golang.org/x/sys - > Checks are failing

@boyamurthy
Copy link
Contributor Author

@boyamurthy go: golang.org/x/[email protected] requires golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys - > Checks are failing

Fixed the error @shanmydell .

Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanmydell shanmydell merged commit 91649bd into main Jan 6, 2022
@shanmydell shanmydell deleted the Feature_149_go_1.17 branch January 6, 2022 06:56
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants