Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating reverseproxy module #431

Merged

Conversation

harshitap26
Copy link

Description

PR to update the reverseproxy module, so that the module can be imported, and functions can be reused in the observability module.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Able to successfully build the images and Install the Driver.

@@ -1,4 +1,4 @@
module revproxy/v2
module github.com/dell/csi-powermax/csireverseproxy/v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering how this would be fixed. good stuff.

@harshitap26 harshitap26 merged commit 7ea778f into usr/spark/mount-credentials Jan 30, 2025
5 of 6 checks passed
@harshitap26 harshitap26 deleted the usr/harshitap26/mount_credentials branch January 30, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants