Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated unit tests for symmetrix #429

Merged

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Jan 29, 2025

Description

PR targets the usr/spark/unit-test-improvements branch.

Increases code coverage for the symmetrix package to 92.3%

# go test -cover -race -count 1 ./...
        github.com/dell/csi-powermax/v2/pkg/symmetrix/mocks             coverage: 0.0% of statements
ok      github.com/dell/csi-powermax/v2/pkg/symmetrix   1.051s  coverage: 92.3% of statements

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Unit tests were successfully run for this package.

@tdawe tdawe merged commit d5ebc05 into usr/spark/unit-test-improvements Jan 30, 2025
6 of 7 checks passed
@tdawe tdawe deleted the usr/tdawe/symmetrix-unit-tests branch January 30, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants