Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates request objects for replication int test #42

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

delldubey
Copy link
Contributor

Description

This PR fixes failing integration tests. Updating the request object as per newly introduced replication params fixes the issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#138
dell/csm#143

Checklist:

  • Have you run format, vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Unit test. integration and Cluster tests.

Sorry, something went wrong.

shanmydell and others added 2 commits December 28, 2021 01:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@shanmydell
Copy link
Collaborator

@delldubey : Add the Remote SRP changes in this file as well https://github.com/dell/csi-powermax/blob/main/env.sh

@shanmydell shanmydell self-requested a review December 28, 2021 07:46
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote SRP id has to be added in env.sh as well

@delldubey
Copy link
Contributor Author

Remote SRP id has to be added in env.sh as well

Added

@delldubey delldubey requested a review from mahesr2 December 28, 2021 10:16
Copy link
Contributor

@mahesr2 mahesr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@shanmydell shanmydell merged commit 7492499 into main Dec 28, 2021
@shanmydell shanmydell deleted the fix_replication_tests branch December 28, 2021 10:39
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants