Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 1.23 support #40

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Adding 1.23 support #40

merged 2 commits into from
Dec 14, 2021

Conversation

boyamurthy
Copy link
Contributor

This PR contains

  1. New sample file for k8 1.23
  2. Updated K8 supported versions

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#136

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

@prablr79
Copy link
Collaborator

@boyamurthy please make sure you test the same version side cars for previous K8 versions.

@boyamurthy
Copy link
Contributor Author

@boyamurthy please make sure you test the same version side cars for previous K8 versions.

yes @prablr79 , will use the same side car version for k8 1.21 and 1.22 .

@boyamurthy boyamurthy merged commit 5f7bd58 into main Dec 14, 2021
@boyamurthy boyamurthy deleted the Feature_136_1.23_support branch December 14, 2021 16:37
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
* Adding 1.23 support

* updated sidecar registrar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants