Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang.org/x/net pkg update #395

Merged
merged 1 commit into from
Dec 30, 2024
Merged

golang.org/x/net pkg update #395

merged 1 commit into from
Dec 30, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Dec 30, 2024 •
edited
Loading

Description

golang.org/x/net pkg update

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@suryagupta4 suryagupta4 self-assigned this Dec 30, 2024
prablr79
prablr79 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkshaySainiDell AkshaySainiDell merged commit 1675c61 into main Dec 30, 2024
6 checks passed
@AkshaySainiDell AkshaySainiDell deleted the usr/suryagupta4/net-pkg-update branch December 30, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@prablr79 prablr79 prablr79 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees

@suryagupta4 suryagupta4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suryagupta4 @prablr79 @karthikk92 @AkshaySainiDell @rishabhatdell