Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gosec CWE fix #394

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Gosec CWE fix #394

merged 1 commit into from
Dec 24, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Dec 24, 2024

Description

Ignored the Gosec warning for the AddEventHandler function, as it doesn't return any errors, but Gosec is flagging it for potential unhandled errors.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

gosec reported no errors:
image

@rishabhatdell rishabhatdell merged commit 8914c88 into main Dec 24, 2024
6 checks passed
@rishabhatdell rishabhatdell deleted the usr/suryagupta4/gosec-fix branch December 24, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants