Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 126 dirty bit fix #39

Merged
merged 10 commits into from
Dec 8, 2021
Merged

Bug 126 dirty bit fix #39

merged 10 commits into from
Dec 8, 2021

Conversation

boyamurthy
Copy link
Contributor

Fixing dirty flag in build version .

  1. added go.sum changes
  2. changed go version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#126

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • [X ] Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@boyamurthy boyamurthy merged commit b25da0b into main Dec 8, 2021
@boyamurthy boyamurthy deleted the bug_126_dirty_bit_fix branch December 13, 2021 10:47
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@boyamurthy @Sahiba-Gupta
Bug 126 dirty bit fix (#39)
bc90455 
* fixing dirty bit flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmydell shanmydell shanmydell approved these changes

@SinuChacko SinuChacko SinuChacko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyamurthy @SinuChacko @shanmydell