Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions #367

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Update actions #367

merged 3 commits into from
Nov 13, 2024

Conversation

shaynafinocchiaro
Copy link
Contributor

Description

PR to remove unit test action and consolidate into reusable actions.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

gallacher
gallacher previously approved these changes Nov 12, 2024
@shaynafinocchiaro shaynafinocchiaro dismissed gallacher’s stale review November 13, 2024 13:17

The merge-base changed after approval.

gallacher
gallacher previously approved these changes Nov 13, 2024
@mjsdell mjsdell merged commit 86b9fb4 into main Nov 13, 2024
4 of 6 checks passed
@mjsdell mjsdell deleted the update-actions branch November 13, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants