Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gobrick to latest commit #338

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Update gobrick to latest commit #338

merged 2 commits into from
Oct 16, 2024

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Oct 15, 2024 •
edited
Loading

Description

Update gobrick to latest commit.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1447
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the fix with powermax driver and validated that the wwids are getting removed from the /etc/multipath/wwids file
    image
    image

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review October 16, 2024 05:14
@AkshaySainiDell AkshaySainiDell merged commit 4b0a341 into main Oct 16, 2024
5 checks passed
@anandrajak1 anandrajak1 deleted the update-gobrick branch October 17, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkshaySainiDell @suryagupta4 @adarsh-dell