Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating supported platforms #28

Merged
merged 1 commit into from
Nov 12, 2021
Merged

updating supported platforms #28

merged 1 commit into from
Nov 12, 2021

Conversation

boyamurthy
Copy link
Contributor

@boyamurthy boyamurthy commented Nov 12, 2021 •
edited
Loading

This PR includes ,

removing the k8 1.19 values file.
updated Openshift 4.9 as supported platform .

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#96

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

shanmydell
shanmydell approved these changes Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delldubey
delldubey approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@boyamurthy boyamurthy merged commit 773b32c into main Nov 12, 2021
@shanmydell shanmydell deleted the supported_platform branch November 12, 2021 12:15
This was referenced Nov 16, 2021
Closed
Closed
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@boyamurthy @Sahiba-Gupta
updating supported platforms (#28)
ea4e758 
Co-authored-by: root <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delldubey delldubey delldubey approved these changes

@shanmydell shanmydell shanmydell approved these changes

@elahinuman elahinuman Awaiting requested review from elahinuman

@mjsdell mjsdell Awaiting requested review from mjsdell

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyamurthy @shanmydell @delldubey