Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating verify script with latest OpenShift version #145

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Updating verify script with latest OpenShift version #145

merged 1 commit into from
Nov 23, 2022

Conversation

shanmydell
Copy link
Collaborator

@shanmydell shanmydell commented Nov 23, 2022 •
edited
Loading

Description

Updating verify script with latest OpenShift version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#557
dell/csm#480

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

boyamurthy
boyamurthy approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tssushma
tssushma approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boyamurthy boyamurthy merged commit 62e0c3e into main Nov 23, 2022
This was linked to issues Nov 23, 2022
[FEATURE]: CSM support for Openshift 4.11 dell/csm#480
Closed
[BUG]: Verify script is missing latest Openshift version dell/csm#557
Closed
@shanmydell shanmydell deleted the update_latest_openshift branch November 24, 2022 10:21
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@shanmydell @Sahiba-Gupta
Update verify-csi-powermax.sh (#145)
9843ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssushma tssushma tssushma approved these changes

@boyamurthy boyamurthy boyamurthy approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@delldubey delldubey Awaiting requested review from delldubey

@mjsdell mjsdell Awaiting requested review from mjsdell

@nidtara nidtara Awaiting requested review from nidtara

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

@shampavman shampavman Awaiting requested review from shampavman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Verify script is missing latest Openshift version [FEATURE]: CSM support for Openshift 4.11
3 participants
@shanmydell @boyamurthy @tssushma