Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update values to use patched vgs #94

Merged
merged 1 commit into from
May 24, 2022
Merged

update values to use patched vgs #94

merged 1 commit into from
May 24, 2022

Conversation

JacobGros
Copy link
Collaborator

@JacobGros JacobGros commented May 18, 2022

Description

This PR updates values file to use patched VGS version 1.0.1, as 1.0.0 was found to have some issues with scaling.
We should not merge this PR until vgs 1.0.1 is officially released.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#292

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Replaced nightly job with this image- it was able to run all testing

Copy link
Contributor

@nb950 nb950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a doc update needed ?
2.2.0 driver customers should not use this image because its not tested ?

@JacobGros JacobGros changed the title [WAIT TO MERGE] update values to use patched vgs update values to use patched vgs May 24, 2022
@JacobGros JacobGros merged commit 983bc46 into main May 24, 2022
@JacobGros JacobGros deleted the update-vgs-version branch May 24, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants