Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sidecars #75

Merged
merged 1 commit into from
Feb 24, 2022
Merged

update sidecars #75

merged 1 commit into from
Feb 24, 2022

Conversation

JacobGros
Copy link
Collaborator

@JacobGros JacobGros commented Feb 23, 2022

Description

This PR updates the sidecars used for driver

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#182

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed driver with new sidecars and ran certify test
  • Installed VGS and driver with new sidecars and ran VGS helm test

@nb950
Copy link
Contributor

nb950 commented Feb 23, 2022

this has side effects related to vg snap , because snap sidecar is updated to 5.x , do we update VG as well and test the driver portion of the extentions ?

@JacobGros
Copy link
Collaborator Author

I did run VGS helm test to make sure it worked with the new sidecar
We also have a story to make needed updates in VGS

@JacobGros JacobGros merged commit bd304b9 into main Feb 24, 2022
@anandrajak1 anandrajak1 deleted the update-sidecars branch October 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants