Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ubi and go version #67

Merged
merged 1 commit into from
Feb 7, 2022
Merged

update ubi and go version #67

merged 1 commit into from
Feb 7, 2022

Conversation

JacobGros
Copy link
Collaborator

@JacobGros JacobGros commented Feb 7, 2022

Description

Updates ubi image to 8.5-230
and GO version to 1.17

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#183

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built image and provisioned some volumes with it

Copy link
Collaborator

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathsreekanth
Copy link
Collaborator

@JacobGros wil lthe changes to VGS for the same be in a separate PR?

@JacobGros
Copy link
Collaborator Author

@JacobGros wil lthe changes to VGS for the same be in a separate PR?

Those changes are in the PR: dell/csi-volumegroup-snapshotter#20

@JacobGros JacobGros merged commit 2e4c721 into main Feb 7, 2022
@JacobGros JacobGros deleted the update-ubi branch February 7, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants