update helm chart to allow complex k8s versions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooseppi-luna
requested review from
abhi16394,
bharathsreekanth,
JacobGros,
mjsdell,
nb950 and
yifeijin
as code owners
nb950
reviewed
Feb 6, 2022
helm/csi-vxflexos/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| appVersion: "2.1.0" | |||
| kubeVersion: ">= 1.21.0 < 1.24.0" | |||
| kubeVersion: ">= 1.21.0-0 < 1.24.0-0" | |||
There was a problem hiding this comment.
un desired side effect can occur , k8s alpha or beta unstable version will also be supported with this fix
example these k8s versions should be not be supported but this check will allow it
v1.22.0-beta.2
v1.23.1-rc.0
5 tasks
JacobGros
approved these changes
Feb 7, 2022
bharathsreekanth
approved these changes
Feb 7, 2022
| @@ -1,6 +1,9 @@ | |||
| apiVersion: v2 | |||
| appVersion: "2.1.0" | |||
| kubeVersion: ">= 1.21.0 < 1.24.0" | |||
| # If you are using a complex K8s version like "v1.21.3-mirantis-1", use this kubeVersion check instead | |||
There was a problem hiding this comment.
Did you want to reword complex version to extended version, so they are consistent with the doc changes you are making? Just a suggestion, you can ignore this, not a must change imo.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The standard kubeVersion check in the Helm chart will fail -- for example, if the k8s version is
v1.21.3-mirantis-1, the install will abort even if the kubeVersion in the helm chart was specified as>= 1.21.0 < 1.24.0. Adding a-0to the end of the version numbers in the kubeVersion field fixes this issue, but it also allows installation of the driver on pre-release alpha and beta versions, which is not supported. Therefore, to make it possible to install the driver on a kubernetes system with an extended version while still blocking pre-release versions of kubernetes, this PR adds a commented-out version of thekubeVersioncheck that includes the-0at the end of the version check and a note explaining it to users.GitHub Issues
dell/csm#128
Checklist:
How Has This Been Tested?
Successfully installed the driver with the alternate
kubeVersioncheck on an MKE setup.