Fix for sidecar installation failure if k8s worker nodes are not in ~/.ssh/known_hosts #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmilarama
changed the title
nb950
reviewed
Jan 6, 2022
| @@ -370,15 +370,24 @@ function verify_authorization_proxy_server() { | |||
| WGET=$(ssh ${NODEUSER}@"${node}" "which wget") | |||
| if [ -x "${WGET}" ]; then | |||
| log info "Running wget on "${node}"" | |||
| nr=1 | |||
| if [ "${insecure}" == "true" ] | |||
| then | |||
| resp=$(ssh ${NODEUSER}@"${node}" wget --no-check-certificate --server-response --spider --quiet https://"${proxyHost}" 2>&1) | |||
There was a problem hiding this comment.
why not set log level to get rid of warning line , then you dont need to look for second line in output ?
ssh -o LogLevel=error xxx
There was a problem hiding this comment.
I'm not sure if that affects any of the other responses. This way seems the least intrusive.
jooseppi-luna
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with sidecar installation failure when the remote k8s worker nodes have not yet been added to the ~/.ssh/known_hosts file. While running SSH commands to check connectivity to the authorization proxy there is an additional message in the response "Warning: Permanently added '1.2.3.4' (ECDSA) to the list of known hosts.". This PR adds changes to ignore this warning message to get the response code in the next line.
GitHub Issues
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Tested verify,sh script for driver installation.