Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListVolumes Capability #370

Merged
merged 13 commits into from
Dec 9, 2024
Merged

Add ListVolumes Capability #370

merged 13 commits into from
Dec 9, 2024

Conversation

JacobGros
Copy link
Collaborator

@JacobGros JacobGros commented Dec 6, 2024

Description

This PR adds the ListVolumes capability
This capability is only returned when health-monitor is not enabled. This is because we want the health monitor to use the GetVolume call instead of ListVolumes.
This is because health monitor doesn't use the max entries field in its listVolumeRequest, meaning all volumes get returned, and the driver isn't able to return a grpc to the health monitor when array has a lot of volumes (90+). We experimented with setting max entries field to 50 and that seemed to work for health monitor, but it broke the sanity tests related to ListVolumes.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran a cert-csi provisioning with new image
  • Installed driver w/ and w/o HM, observed the correct capabilities were returned

@JacobGros JacobGros marked this pull request as ready for review December 6, 2024 19:21
@karthikk92 karthikk92 merged commit 9f67ab8 into main Dec 9, 2024
6 checks passed
@karthikk92 karthikk92 deleted the pub/max-entires branch December 9, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants