-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ListVolumes Capability #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobGros
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
bpjain2004,
donatwork and
tdawe
as code owners
December 6, 2024 19:21
alikdell
approved these changes
Dec 6, 2024
suryagupta4
approved these changes
Dec 8, 2024
karthikk92
approved these changes
Dec 9, 2024
AkshaySainiDell
approved these changes
Dec 9, 2024
bpjain2004
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ListVolumes capability
This capability is only returned when health-monitor is not enabled. This is because we want the health monitor to use the GetVolume call instead of ListVolumes.
This is because health monitor doesn't use the max entries field in its listVolumeRequest, meaning all volumes get returned, and the driver isn't able to return a grpc to the health monitor when array has a lot of volumes (90+). We experimented with setting max entries field to 50 and that seemed to work for health monitor, but it broke the sanity tests related to ListVolumes.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration