Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UT, update to latest goscaleio #332

Merged

Conversation

bharathsreekanth
Copy link
Collaborator

@bharathsreekanth bharathsreekanth commented Sep 24, 2024

Description

Update UT, use latest commit of goscaleio.

This is sort of internal PR, merge will be to another internal branch. Main PR will be opened against that branch.

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| (dell/csm#663) |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Test B

@bharathsreekanth bharathsreekanth merged commit 27c22bd into usr/Harshita_Pandey/sdc-optional Sep 24, 2024
2 of 3 checks passed
bharathsreekanth added a commit that referenced this pull request Oct 1, 2024
* fix UT, update to latest goscaleio
@anandrajak1 anandrajak1 deleted the usr/sreekb/hp-sdc-optional branch October 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants