Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeowners update 20240821 #324

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Codeowners update 20240821 #324

merged 3 commits into from
Aug 28, 2024

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Aug 22, 2024

Description

Update of CODEOWNERS based on new component ownership. Also fixed new linter errors as the golang-cilint tool got updated again yesterday.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1422

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran cert-csi provisioning test to validate the driver worked and provisioned volumes.
# cert-csi functional-test  provisioning --sc vxflexos-ext4
[2024-08-25 15:41:24]  INFO Starting cert-csi; ver. 1.5.0
[2024-08-25 15:41:24]  INFO Using EVENT observer type
[2024-08-25 15:41:24]  INFO Using config from /etc/kubernetes/admin.conf
[2024-08-25 15:41:24]  INFO Successfully loaded config. Host: https://X.X.X.X:XXXX
[2024-08-25 15:41:24]  INFO Created new KubeClient
[2024-08-25 15:41:24]  INFO Successfully created namespace functional-test
[2024-08-25 15:41:24]  INFO Using default number of volumes
[2024-08-25 15:41:24]  INFO Using default number of pods
[2024-08-25 15:41:24]  INFO Using default volume size 3Gi
[2024-08-25 15:41:24]  INFO Using default image: docker.io/centos:latest
[2024-08-25 15:41:24]  INFO Creating 1 pods, each with 5 volumes
[2024-08-25 15:41:24]  INFO Waiting for all pods in functional-test to be READY
[2024-08-25 15:41:46]  INFO All pods are ready in 22.119387987s
[2024-08-25 15:41:49]  INFO SUCCESS: ProvisioningSuite in 25.095234203s
[2024-08-25 15:41:49]  INFO Trying to connect to cluster...
[2024-08-25 15:41:49]  INFO Created new KubeClient
[2024-08-25 15:41:49]  INFO During this run 100.0% of suites succeeded

Copy link
Collaborator

@AronAtDell AronAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only Codeowners changes in this PR?

@donatwork
Copy link
Contributor Author

@AronAtDell yes it was initially meant to be CODEOWNERS only change but the linter flagged a few issues that I had to fix since passing linter checks are required. I ran a quick sanity test to make sure that the code still works as expected. A lot more work than I had planned.

@donatwork donatwork requested a review from AronAtDell August 27, 2024 21:05
@donatwork donatwork merged commit 03a963f into main Aug 28, 2024
5 checks passed
@donatwork donatwork deleted the codeowners-update-20240821 branch August 28, 2024 09:12
Copy link
Collaborator

@eric-young eric-young left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplification of the CODEOWNERS file, it should only contain people that you NEED to look at PRs and not everyone that CAN. :)

The rest of the changes look good as well, I made the same changes in a pending PR so I can deal with the merge conflicts when they arise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants