Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up the csi-spec version from 1.5 to 1.6 in csi-powerflex #256

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

KshitijaKakde
Copy link
Contributor

@KshitijaKakde KshitijaKakde commented Oct 16, 2023

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#905

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

adarsh-dell
adarsh-dell previously approved these changes Oct 16, 2023
@adarsh-dell
Copy link
Contributor

Hello @KshitijaKakde, it's advisable to consolidate all these modifications within a feature branch rather than merging them directly into the main branch until the entire feature is fully implemented.

While I understand that these changes won't affect the core functionality, they do introduce new struct definitions, so it's best to confine them to the feature branch for now.

Thanks,
Adarsh

@KshitijaKakde KshitijaKakde changed the base branch from main to CSI-spec-1.6 October 16, 2023 12:14
@KshitijaKakde
Copy link
Contributor Author

Hello @KshitijaKakde, it's advisable to consolidate all these modifications within a feature branch rather than merging them directly into the main branch until the entire feature is fully implemented.

While I understand that these changes won't affect the core functionality, they do introduce new struct definitions, so it's best to confine them to the feature branch for now.

Thanks, Adarsh

Done @adarsh-dell

@KshitijaKakde KshitijaKakde merged commit f0678f1 into CSI-spec-1.6 Oct 17, 2023
3 of 5 checks passed
@anandrajak1 anandrajak1 deleted the csi-version branch October 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants