-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename sdc #153
Merged
Merged
Rename sdc #153
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f4203c7
added support for renaming SDC
khareRajshree 92c2e79
node.go updated
khareRajshree 3b08004
node.go updated
khareRajshree 3ece0b8
unit tests added
khareRajshree ff84122
unit tests updated
khareRajshree cdbebaa
node.go updated
khareRajshree fc03fd4
node.go updated
khareRajshree ba6e8a0
node.go updated
khareRajshree 9f4c548
node.go updated
khareRajshree 4ca7f2b
UTs updated
khareRajshree fda4b8a
node.go updated
khareRajshree 96c1b13
UTs updated
khareRajshree f8b081a
modified renameSdc unit-tests and hostName logic.
VamsiSiddu-7 5885386
added the missing comment in values.yaml for renamesdc.
VamsiSiddu-7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
{ | ||
"versionInfo": null, | ||
"perfProfile": "Default", | ||
"sdcApproved": true, | ||
"osType": "Linux", | ||
"mdmConnectionState": "Connected", | ||
"memoryAllocationFailure": null, | ||
"socketAllocationFailure": null, | ||
"softwareVersionInfo": null, | ||
"sdcGuid": "9E56672F-2F4B-4A42-BFF4-88B6846FBFDA", | ||
"installedSoftwareVersionInfo": "R2_6.0.0", | ||
"kernelVersion": "3.10.0", | ||
"kernelBuildNumber": null, | ||
"sdcIp": "127.1.1.11", | ||
"sdcApprovedIps": null, | ||
"systemId": "14dbbf5617523654", | ||
"name": "__NAME__", | ||
"id": "__ID__", | ||
"links": [ | ||
{ | ||
"rel": "self", | ||
"href": "/api/instances/Sdc::d0f055a700000000" | ||
}, | ||
{ | ||
"rel": "/api/Sdc/relationship/Statistics", | ||
"href": "/api/instances/Sdc::d0f055a700000000/relationships/Statistics" | ||
}, | ||
{ | ||
"rel": "/api/Sdc/relationship/Volume", | ||
"href": "/api/instances/Sdc::d0f055a700000000/relationships/Volume" | ||
}, | ||
{ | ||
"rel": "/api/parent/relationship/systemId", | ||
"href": "/api/instances/System::14dbbf5617523654" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can simplify code here if you would like (nothing wrong with what you have).
newName = hostName
if (sdcPrefix > 0) newName = opts.SdcPrefix + "_" + newName.
Basically remove the else clause. Not major, I am fine with as is.