Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate snapshot name to max characters length #112

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

falfaroc
Copy link
Contributor

Description

During csi-sanity testing, there was no verification that the adjusted name of the snapshot name would be 31 characters or greater. This caused a truncated name of less than 31 characters to cause an out-of-bound exception during testing.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#350

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Tested locally with the csi-sanity tests. No crashing of snapshot name creations occurred.

jooseppi-luna
jooseppi-luna previously approved these changes Jul 14, 2022
@falfaroc falfaroc dismissed stale reviews from jooseppi-luna and bharathsreekanth via 04a76fa July 18, 2022 15:24
@falfaroc falfaroc force-pushed the bugfix/max-snapshot-name-length branch from 402a358 to 04a76fa Compare July 18, 2022 15:24
@falfaroc falfaroc merged commit c313f7f into main Jul 19, 2022
@anandrajak1 anandrajak1 deleted the bugfix/max-snapshot-name-length branch October 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants