ut fix

dell · Oct 17, 2023 · 78032e9 · 78032e9
1 parent 9335fad
commit 78032e9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/service/ephemeral.go b/service/ephemeral.go
@@ -63,6 +63,7 @@ func (s *service) ephemeralNodePublish(
 
 	_, err := os.Stat(ephemeralStagingMountPath)
 	if err != nil {
+		Log.Warnf("Unable to check stat of file: %s with error: %v", ephemeralStagingMountPath, err.Error())
 		if os.IsNotExist(err) {
 			Log.Debug("path does not exist, will attempt to create it")
 			err = os.MkdirAll(ephemeralStagingMountPath, 0750)
@@ -71,7 +72,6 @@ func (s *service) ephemeralNodePublish(
 				return nil, status.Error(codes.Internal, "Unable to create directory for mounting ephemeral volumes")
 			}
 		}
-		Log.Errorf("Unable to check stat of file: %s with error: %v", ephemeralStagingMountPath, err.Error())
 	}
 
 	volID := req.GetVolumeId()

diff --git a/service/mount.go b/service/mount.go
@@ -551,6 +551,7 @@ func contains(list []string, item string) bool {
 func mkfile(path string) (bool, error) {
 	st, err := os.Stat(path)
 	if err != nil {
+		Log.Infof("Unable to check stat of file: %s with error: %v", path, err.Error())
 		if os.IsNotExist(err) {
 			/* #nosec G302 G304 */
 			file, err := os.OpenFile(path, os.O_CREATE, 0755)
@@ -568,7 +569,6 @@ func mkfile(path string) (bool, error) {
 			Log.WithField("path", path).Debug("created file")
 			return true, nil
 		}
-		Log.Errorf("Unable to check stat of file: %s with error: %v", path, err.Error())
 	}
 	if st.IsDir() {
 		return false, fmt.Errorf("existing path is a directory")
@@ -581,6 +581,7 @@ func mkfile(path string) (bool, error) {
 func mkdir(path string) (bool, error) {
 	st, err := os.Stat(path)
 	if err != nil {
+		Log.Warnf("Unable to check stat of file: %s with error: %v", path, err.Error())
 		if os.IsNotExist(err) {
 			err := os.Mkdir(path, 0755) // #nosec G301
 			if err != nil {
@@ -591,7 +592,6 @@ func mkdir(path string) (bool, error) {
 			Log.WithField("path", path).Debug("created directory")
 			return true, nil
 		}
-		Log.Errorf("Unable to check stat of file: %s with error: %v", path, err.Error())
 	}
 	if !st.IsDir() {
 		return false, fmt.Errorf("existing path is not a directory")

diff --git a/service/service.go b/service/service.go
@@ -786,10 +786,10 @@ func getArrayConfig(ctx context.Context) (map[string]*ArrayConnectionData, error
 
 	_, err := os.Stat(ArrayConfigFile)
 	if err != nil {
+		Log.Errorf("Found error %v while checking stat of file %s ", err, ArrayConfigFile)
 		if os.IsNotExist(err) {
 			return nil, fmt.Errorf(fmt.Sprintf("File %s does not exist", ArrayConfigFile))
 		}
-		fmt.Printf("Found error %v while checking stat of file %s ", err, ArrayConfigFile)
 	}
 
 	config, err := os.ReadFile(filepath.Clean(ArrayConfigFile))

diff --git a/test/integration/step_defs_test.go b/test/integration/step_defs_test.go
@@ -138,7 +138,6 @@ func (f *feature) getArrayConfig() (map[string]*ArrayConnectionData, error) {
 		if os.IsNotExist(err) {
 			return nil, fmt.Errorf(fmt.Sprintf("File %s does not exist", configFile))
 		}
-		fmt.Printf("Found error %v while checking stat of file %s ", err, configFile)
 	}
 
 	config, err := os.ReadFile(filepath.Clean(configFile))