[ISSUE-1186]: fake-attach without DR test automation (e2e), framework utils #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korzepadawid
force-pushed
the
issue-1186-multiple-nodes
branch
from
e6212d3 to
10415be
Compare
korzepadawid
changed the title
mdutka-dell
reviewed
Jul 12, 2024
korzepadawid
changed the title
Signed-off-by: Dawid Korzepa <[email protected]>
Signed-off-by: Dawid Korzepa <[email protected]>
Signed-off-by: Dawid Korzepa <[email protected]>
Signed-off-by: Dawid Korzepa <[email protected]>
korzepadawid
force-pushed
the
issue-1186-multiple-nodes
branch
from
10415be to
e0cfbf7
Compare
Signed-off-by: Dawid Korzepa <[email protected]>
Co-authored-by: korzepadawwid <[email protected]> Co-authored-by: mdutka-dell <[email protected]> Signed-off-by: Dawid Korzepa <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
- Coverage 71.04% 71.01% -0.03%
==========================================
Files 105 105
Lines 10592 10592
==========================================
- Hits 7525 7522 -3
- Misses 2759 2761 +2
- Partials 308 309 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: korzepadawwid <[email protected]> Co-authored-by: mdutka-dell <[email protected]> Signed-off-by: Dawid Korzepa <[email protected]>
korzepadawid
commented
Jul 12, 2024
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def keep_drive_count(drive_utils_executors: dict[str, DriveUtils]) -> Generator[None, None, None]: |
There was a problem hiding this comment.
to make sure we don't disconnect a drive during a test without plugging it again
Signed-off-by: Dawid Korzepa <[email protected]>
mdutka-dell
approved these changes
Jul 12, 2024
Kacper-Michon-DELL
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1186
Describe your changes
PR checklist
Testing
Provide test details