[issue-1088] alerts for missing disks #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1102 +/- ##
==========================================
+ Coverage 72.79% 72.81% +0.02%
==========================================
Files 63 63
Lines 8953 8961 +8
==========================================
+ Hits 6517 6525 +8
Misses 2148 2148
Partials 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kacper-Michon-DELL
approved these changes
Mar 1, 2024
rafalw82
reviewed
Mar 1, 2024
pkg/node/volumemgr.go
Outdated
| @@ -1110,6 +1110,12 @@ func (m *VolumeManager) createEventsForDriveUpdates(updates *driveUpdates) { | |||
| m.createEventForDriveStatusChange( | |||
| updDrive.CurrentState, updDrive.PreviousState.Spec.Status, updDrive.CurrentState.Spec.Status) | |||
| } | |||
| if updDrive.CurrentState.Spec.Status == apiV1.DriveStatusOffline { | |||
There was a problem hiding this comment.
Is it possible that we get two same events the one generated in line 1111 and this new one?
There was a problem hiding this comment.
For normal flow is should not be possible, however to to be 100% safe I've changed the code to handle this situation. Thank you!
rafalw82
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves ##1088
Sending DriveSuccessfullyRemoved alert for successfully removed missing disks
PR checklist
Testing
Whole regression tests