Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-1088] Drive status is not set to OFFLINE when health is changed to BAD #1089

Closed
wants to merge 2 commits into from

Conversation

Kacper-Michon-DELL
Copy link
Collaborator

Purpose

Resolves #1088

Drive status is not set to OFFLINE when health is changed to BAD

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Provide test details

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5847f2) 72.84% compared to head (bbf0a7d) 72.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   72.84%   72.87%   +0.02%     
==========================================
  Files          63       63              
  Lines        8949     8957       +8     
==========================================
+ Hits         6519     6527       +8     
  Misses       2142     2142              
  Partials      288      288              
Flag Coverage Δ
unittests 72.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mishoyama
Copy link
Collaborator

@Kacper-Michon-DELL it shouldn't change to OFFLINE. Drive can have BAD health, but be ONLINE. ONLINE means it's detected by CSI

Copy link
Collaborator

@mishoyama mishoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't change to OFFLINE. Drive can have BAD health, but be ONLINE. ONLINE means it's detected by CSI

@katarzyna-kulpa katarzyna-kulpa deleted the issue-1088 branch March 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DriveReadyForRemoval alert is not cleared for missing disk removal
2 participants