[Issue-1084] Addjust scheduler extender algorithm #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
+ Coverage 72.76% 72.78% +0.02%
==========================================
Files 63 63
Lines 8949 8956 +7
==========================================
+ Hits 6512 6519 +7
- Misses 2147 2149 +2
+ Partials 290 288 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrzej Zukowski <[email protected]>
mishoyama
reviewed
Feb 19, 2024
| return | ||
| pod := extenderArgs.Pod | ||
| var hostPriority []schedulerapi.HostPriority | ||
| requests, _ := e.gatherCapacityRequestsByProvisioner(context.TODO(), pod) |
There was a problem hiding this comment.
Do we need to check error?
mishoyama
reviewed
Feb 19, 2024
| ll.Errorf("Unable to score %v", err) | ||
| return | ||
| } | ||
| ll.Infof("Score results for pod %s: %v", pod, hostPriority) |
There was a problem hiding this comment.
Better to print just pod namespace and name
mishoyama
reviewed
Feb 19, 2024
| return | ||
| pod := extenderArgs.Pod | ||
| var hostPriority []schedulerapi.HostPriority | ||
| requests, _ := e.gatherCapacityRequestsByProvisioner(context.TODO(), pod) |
There was a problem hiding this comment.
Better to replace TODO context by context with value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1084
Describe your changes
PR checklist
Testing
Provide test details