Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-1051] Handle Kubelet's Wrong CSI Call Inconsistent with Real Volume Status for OBS Release 1.3 #1052

Closed
wants to merge 15 commits into from
Closed

[ISSUE-1051] Handle Kubelet's Wrong CSI Call Inconsistent with Real Volume Status for OBS Release 1.3 #1052

wants to merge 15 commits into from

Conversation

CraneShiEMC
Copy link
Collaborator

Purpose

Resolves #1051

  1. Handle Kubelet's Wrong CSI Call Inconsistent with Real Volume Status
  2. Proceed Kubelet's CSI call also on Failed Volume

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Provide test details

CraneShiEMC and others added 15 commits July 31, 2023 12:04
@CraneShiEMC @yimingwangdell
[ISSUE-1018] Refine Storage Group Feature (#1044)
fc9d4f4 
* [ISSUE-1040] fix pip3 install PyYAML failed. (#1041)

Signed-off-by: yimingwangdell <[email protected]>

* [ISSUE-1018] Refine Storage Group Feature (#1031)

* add StorageGroupStatus

Signed-off-by: Shi, Crane <[email protected]>

* support StorageGroupStatus in current workflows

Signed-off-by: Shi, Crane <[email protected]>

* refine log

Signed-off-by: Shi, Crane <[email protected]>

* refine error handling

Signed-off-by: Shi, Crane <[email protected]>

* trigger storage group resync if applicable in drive removal

Signed-off-by: Shi, Crane <[email protected]>

* A drive whose Usage is REMOVED will not be selected in any storage group and its existing sg label takes no effect

Signed-off-by: Shi, Crane <[email protected]>

* sg feature will not apply to drive physically removed

Signed-off-by: Shi, Crane <[email protected]>

* handle the drive removal case of drive with manual sg label

Signed-off-by: Shi, Crane <[email protected]>

* fix go lint error

Signed-off-by: Shi, Crane <[email protected]>

* add UT case for drive-removal-triggered sg sync

Signed-off-by: Shi, Crane <[email protected]>

* improve UT coverage

Signed-off-by: Shi, Crane <[email protected]>

* refine sg annotation for drive removal

Signed-off-by: Shi, Crane <[email protected]>

* handle case of invalid sg for drive removal

Signed-off-by: Shi, Crane <[email protected]>

* also exclude removing sg for trigger sg resync in drive removal

Signed-off-by: Shi, Crane <[email protected]>

* refine sg removal status handling

Signed-off-by: Shi, Crane <[email protected]>

* Revert "refine error handling"

This reverts commit 06607e7.

Signed-off-by: Shi, Crane <[email protected]>

* refine log and some code logic

Signed-off-by: Shi, Crane <[email protected]>

* try to add immutability validation rule to storagegroup spec

Signed-off-by: Shi, Crane <[email protected]>

* upgrade controller-gen version to v0.9.2

Signed-off-by: Shi, Crane <[email protected]>

* add storagegroupcontroller UT initial

Signed-off-by: Shi, Crane <[email protected]>

* Revert "add storagegroupcontroller UT initial"

This reverts commit 1ea8660.

Signed-off-by: Shi, Crane <[email protected]>

* add storagegroupcontroller UT

Signed-off-by: Shi, Crane <[email protected]>

* fix

Signed-off-by: Shi, Crane <[email protected]>

* add storagegroupcontroller UT

Signed-off-by: Shi, Crane <[email protected]>

* refactor and add UT of storagegroupcontroller

Signed-off-by: Shi, Crane <[email protected]>

* add storagegroupcontroller UT

Signed-off-by: Shi, Crane <[email protected]>

* fix storagegroupcontroller UT

Signed-off-by: Shi, Crane <[email protected]>

* add storagegroupcontroller UT

Signed-off-by: Shi, Crane <[email protected]>

* refine the logic of sg deletion

Signed-off-by: Shi, Crane <[email protected]>

* refine

Signed-off-by: Shi, Crane <[email protected]>

* fix bug

Signed-off-by: Shi, Crane <[email protected]>

* fix go-lint err

Signed-off-by: Shi, Crane <[email protected]>

* fix go-lint error

Signed-off-by: Shi, Crane <[email protected]>

* add drive IsClean support, decrease k8s api call, remove manual sg labeling support

Signed-off-by: Shi, Crane <[email protected]>

* fix

Signed-off-by: Shi, Crane <[email protected]>

* fix

Signed-off-by: Shi, Crane <[email protected]>

* fix UT

Signed-off-by: Shi, Crane <[email protected]>

* refine corner case handling

Signed-off-by: Shi, Crane <[email protected]>

* fix

Signed-off-by: Shi, Crane <[email protected]>

* refine and add UT to storagegroupcontroller

Signed-off-by: Shi, Crane <[email protected]>

* refine storagegroupcontroller and add UT

Signed-off-by: Shi, Crane <[email protected]>

* make controller svc's k8scache also sync sg and lvg objs'

Signed-off-by: Shi, Crane <[email protected]>

* use k8s cache, re-support sg label manual change and refine in sg ctrl

Signed-off-by: Shi, Crane <[email protected]>

* fix lint err

Signed-off-by: Shi, Crane <[email protected]>

* add storagegroupcontroller UT

Signed-off-by: Shi, Crane <[email protected]>

* add storagegroupcontroller UT

Signed-off-by: Shi, Crane <[email protected]>

* storagegroup controller will not reconcile on drive delete event

Signed-off-by: Shi, Crane <[email protected]>

* not support Health, Status, Usage and IsClean as DriveSelector's MatchFields

Signed-off-by: Shi, Crane <[email protected]>

* in storagegroupcontroller's reconcile, only sync drive when reqName is uuid

Signed-off-by: Shi, Crane <[email protected]>

* refine the logic to avoid nil pointer error

Signed-off-by: Shi, Crane <[email protected]>

* revert the usage of k8scache

Signed-off-by: Shi, Crane <[email protected]>

* add custom storage group proposal draft

Signed-off-by: Shi, Crane <[email protected]>

* refine custom storage group proposal

Signed-off-by: Shi, Crane <[email protected]>

---------

Signed-off-by: CraneShiEMC <[email protected]>

---------

Signed-off-by: yimingwangdell <[email protected]>
Signed-off-by: CraneShiEMC <[email protected]>
Co-authored-by: yimingwangdell <[email protected]>
@CraneShiEMC
[ISSUE-1045] Fake Attach Feature for Non-LVM-Block-Mode Volumes for O…
59a295a 
…BS Release 1.3 (#1048)

* fix pr validation startup failure



* directly use generated file for fake attach block mode



* still use loopback device wrap



* refine code for creating fake device



* fix go lint error



* add mock func implementation



* fix go lint



* fix UT



* refine func



* support fake attach block mode with fake device, add removeLoopDevice,



* fix go lint



* refine



* support clean fake device in fake-attach block-mode



* support non-existing current fake device case



* change fake device dir on host



* refine log



* support the case of get fake device info failure



* clean fake device also in removal of fake-attach block-mode vol



* if fake-device ann is invalid, re-create the fake device and update ann



* fix



* enhance



* refine



* refine



* add comment



* add UT



* add UT



* add UT



* add UT



* check loop device err shouldn't block subsequent op; clean fake device should also check loop device first



* update fake-attach doc accordingly



* fix typo



* refine doc



---------

Signed-off-by: CraneShiEMC <[email protected]>
@CraneShiEMC
for NodeUnstage/NodePublish/NodeUnpublish, also need to retry on Fail…
5f071d6 
…ed volume

Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
fix lint error
2e6ab7f 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
fix UT
fdc5970 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
add UT
a50a7f1 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
add UT
bfb1d98 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
Redo NodeStageVolume if srcPath is not mounted
1a77d43 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
correct stagingTargetPath
d36e785 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
add warning log for redo NodeStageVolume
4376b10 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
fix that, in multi-pod case, successful unpublish volume cannot resum…
c835b96 
…e failed volume status

Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
unlock volume to redo NodeStageVolume if applicable in NodePublishVolume
a3abfb9 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
fix issue of outdated volume
af81d9a 
Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
Revert "[ISSUE-1038] 1.3.0 branched out. Change version to 1.4.0 for …
aee7d03 
…new release. (#1039)"

This reverts commit b5ffc6c.

Signed-off-by: Shi, Crane <[email protected]>
@CraneShiEMC
Merge branch 'rel/objectscale-1.3' of https://github.com/dell/csi-bar…
e65eb59 
…emetal into bugfix-handle-kubelet-wrong-call-obs-1.3

Signed-off-by: Shi, Crane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to Handle Kubelet's Wrong CSI Call Inconsistent with Real Volume Status
1 participant
@CraneShiEMC