Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Quay based centos image #84

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Use Quay based centos image #84

merged 6 commits into from
Sep 10, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Sep 9, 2024 •
edited
Loading

Description

Use Quay based centos image to fix docker rate limit issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Sanity test by building cert-csi binary and run cert-csi scale test against csi-powerscale driver.

AkshaySainiDell
AkshaySainiDell requested changes Sep 10, 2024
View reviewed changes
pkg/testcore/runner/perf-runner.go Outdated Show resolved Hide resolved
pkg/testcore/suites/functional-suites.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chimanjain chimanjain merged commit 6a2ac83 into main Sep 10, 2024
4 checks passed
@chimanjain chimanjain deleted the quay-centos branch September 10, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chimanjain @AkshaySainiDell @adarsh-dell