Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for getting auth user list #113

Merged
merged 16 commits into from
Sep 20, 2024

Conversation

meenakshidembi691
Copy link
Contributor

Description

Made the changes in the info module to get all user details

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#109

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Functional testing
  • Unit testing

plugins/modules/info.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.88%. Comparing base (c5b1405) to head (aee4376).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...s/module_utils/storage/dell/shared_library/auth.py 60.71% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   81.90%   82.88%   +0.98%     
==========================================
  Files         124      133       +9     
  Lines       13463    14482    +1019     
  Branches     1989     2134     +145     
==========================================
+ Hits        11027    12004     +977     
+ Misses       1830     1828       -2     
- Partials      606      650      +44     
Flag Coverage Δ
units 82.88% <75.00%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sachin-apa
sachin-apa previously approved these changes Sep 19, 2024
@trisha-dell trisha-dell self-requested a review September 20, 2024 05:13
@sachin-apa sachin-apa merged commit ed16092 into dell:main Sep 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: In module user: task to find user apparently tries to create the user
6 participants