Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for alert channel #107

Merged
merged 10 commits into from
Aug 21, 2024

Conversation

Bhavneet-Sharma
Copy link
Contributor

@Bhavneet-Sharma Bhavneet-Sharma commented Aug 7, 2024

Description

Adding Support for alert channels

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Functional Testing

felixs88
felixs88 previously approved these changes Aug 20, 2024
felixs88
felixs88 previously approved these changes Aug 20, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.21407% with 32 lines in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (8a6e181) to head (f0baa53).
Report is 9 commits behind head on main.

Files Patch % Lines
plugins/modules/alert_channel.py 87.67% 11 Missing and 16 partials ⚠️
...module_utils/storage/dell/shared_library/events.py 64.28% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   82.21%   82.10%   -0.11%     
==========================================
  Files         123      127       +4     
  Lines       13307    13790     +483     
  Branches     1965     2039      +74     
==========================================
+ Hits        10940    11322     +382     
- Misses       1767     1844      +77     
- Partials      600      624      +24     
Flag Coverage Δ
units 82.10% <90.21%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trisha-dell
trisha-dell previously approved these changes Aug 20, 2024
sachin-apa
sachin-apa previously approved these changes Aug 21, 2024
playbooks/modules/alert_channel.yml Show resolved Hide resolved
@Bhavneet-Sharma Bhavneet-Sharma merged commit b9ef8bb into dell:main Aug 21, 2024
25 checks passed
@Bhavneet-Sharma Bhavneet-Sharma deleted the feature_alert_channel branch August 22, 2024 12:45
@anupamaloke anupamaloke linked an issue Oct 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]:Add support for alert channel and alert rule management
6 participants