Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and playbook for writable snapshot #105

Conversation

Kritika-Bhateja-03
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

plugins/modules/writable_snapshot.py Outdated Show resolved Hide resolved
plugins/modules/writable_snapshot.py Outdated Show resolved Hide resolved
plugins/modules/writable_snapshot.py Outdated Show resolved Hide resolved
plugins/modules/writable_snapshot.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.85714% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (19d8681) to head (3235473).
Report is 2 commits behind head on main.

Files Patch % Lines
plugins/modules/writable_snapshots.py 89.02% 8 Missing and 10 partials ⚠️
...lugins/module_utils/mock_writable_snapshots_api.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   82.23%   82.11%   -0.12%     
==========================================
  Files         123      127       +4     
  Lines       13298    13729     +431     
  Branches     1965     2020      +55     
==========================================
+ Hits        10936    11274     +338     
- Misses       1762     1838      +76     
- Partials      600      617      +17     
Flag Coverage Δ
units 82.11% <92.85%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plugins/modules/writable_snapshots.py Outdated Show resolved Hide resolved
plugins/modules/writable_snapshots.py Outdated Show resolved Hide resolved
plugins/modules/writable_snapshots.py Outdated Show resolved Hide resolved
felixs88
felixs88 previously approved these changes Aug 21, 2024
sachin-apa
sachin-apa previously approved these changes Aug 21, 2024
@Kritika-Bhateja-03 Kritika-Bhateja-03 dismissed stale reviews from sachin-apa and felixs88 via ee6fe89 August 21, 2024 12:06
sachin-apa
sachin-apa previously approved these changes Aug 21, 2024
@Bhavneet-Sharma Bhavneet-Sharma merged commit 82bf2f5 into dell:main Aug 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants