Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update portgroup.py #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

smitty-dell
Copy link

@smitty-dell smitty-dell commented Oct 1, 2024

Added the NVMe_FC option

Description

Added the option for NVMe_FC as a port group option like in the GUI.

GitHub Issues

List the GitHub issues impacted by this PR: N/A

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

We have a Powermax 2500 in the lab that we used to confirm this change worked as expected.

  • We had all ports on the array set to NVMe/FC and then created a portgroup with the new choice and it configured the portgroup as expected with the proper director and ports.

Added the NVMe_FC option
Forgot to edit the documentation.
@smitty-dell smitty-dell marked this pull request as ready for review October 1, 2024 15:50
@sachin-apa
Copy link
Contributor

Waiting for the hardware availability to pick the PR.

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants