Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct comparison operator to enable support for multiple vmk nics #94

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Correct comparison operator to enable support for multiple vmk nics #94

merged 1 commit into from
Apr 18, 2016

Conversation

dwoolger
Copy link

No description provided.

@ggeldenhuis
Copy link

This seems like a really small change that could be easily merged? Any takers at Dell?

@gavin-scott
Copy link

Seems like this should probably be issued against upstream. @dwoolger did you intend to push this to https://github.com/vmware/vmware-vcenter ?

@ggeldenhuis
Copy link

We (Skyscape) are happy to issue against upstream but upstream and Dell has diverged quite a lot and not sure upstream is as active as they used to be. The same request is currently with upstream.

@gavin-scott
Copy link

Definitely true that it's diverged a lot :-(

Change looks correct so we'll get it in here.

@gavin-scott gavin-scott merged commit 2171c3f into dell-asm:master Apr 18, 2016
@ggeldenhuis
Copy link

Thanks! @gavin-scott would you mind sending me a pm on twitter @ggeldenhuis with some contact details? I would love to discuss the possibility of closer collaboration on this and related modules. We have some scope and the will to improve things and would love to collaborate. We are trying to goad vmware into action to get upstream, dell and skyscape forks all on the same page again.

maniacmurphy added a commit to vmware-archive/vmware-vcenter that referenced this pull request Jul 26, 2016
Proposed port of dell-asm#94 - Correct comparison operator to enable support for multiple vmk nics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants