ASM-6588: Apply the vib update on ESXi host

[kaushalgala]

Puppet type and provider for ESXi VIB updates

[kaushalgala]

Here are all relevant PRs:

#113 - Puppet type and provider for ESXi updates
https://github.com/dell-asm/asm-deployer/pull/1613 - ASM-deployer class for mapping "asm::server_update" puppet defined resource
https://github.com/dell-asm/asm/pull/298 - Puppet manifest(asm::server_update) / helper parser function to apply server updates ( firmware and software )

[gavin-scott]

you could just do vibs = Array(resource[:vibs]) or on line below Array(resource[:vibs]).each do |vib_data|

[kaushalgala]

I guess since resource[:vibs] can be an Array of Hash, or a single Hash.
So basically for seconds case, we need single array hash.

Doing Array(resource[:vibs]) leads to array of array, instead of desired array of hash :

i.e. Array(resource[:vibs]) yields
[
["uri_path", "path_value"],
[:vib_path, "vib"], [:nfs_share, "/share"],
[:volume_name, "foo"]
]
whereas, [resource[:vibs]] yields:
[
{ "uri_path" => "path_value"},
{:vib_path => "vib" }, {:nfs_share => "/share"},
{:volume_name => "foo"}
]

[ripienaar]

I think Array(foo) does exactly what you need:

irb(main):002:0> Array(:x)
=> [:x]
irb(main):003:0> Array([:x])
=> [:x]

hmm, wow, scratch that, you're right that's strange:

irb(main):004:0> Array({:x => 1})
=> [[:x, 1]]

[gavin-scott]

Well crap ;-) Good catch @kaushalgala

[kaushalgala]

@gavin-scott , have updated the PR addressing your feedback.