Branch merge 820 to master vmware vcenter 79 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to skip internal SATA Disk configured as in AHCI Mode. These disks has to be used for OS installation or left as-is Earlier PR was not working correctly. Updated the attributed with correct disk object
There was a lot of incorrect behavior with the code that shifted the networks. It was leaving extra network adapters, it would not work if there was the name number of networks on the VM as we're trying to set (even if we're trying to set different networks). This code should help make the behavior more correct overall and should help solve standing issues with network scale up
ASM-6373 Refactored network_interfaces setting code
…-skip-atadisk ASM-6387 ASM to support Urgent Fury vSAN RA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gavin-scott Please review and merge