Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUB-44 : Init changesets #44

Merged
merged 12 commits into from
Jul 21, 2021
Merged

PUB-44 : Init changesets #44

merged 12 commits into from
Jul 21, 2021

Conversation

rohit-gohri
Copy link
Member

@rohit-gohri rohit-gohri commented Jul 20, 2021

Closes PUB-44

New release workflow

On merging to main, a PR to increment version automatically opens and keeps updated. We can merge it anytime and release will be created

New prerelease workflow

Just go to Github releases panel and create a pre-release, the tag should have a -[0-9] suffix to differentiate normal and beta tags.

@rohit-gohri rohit-gohri requested a review from samrocksc July 21, 2021 05:45
samrocksc
samrocksc previously approved these changes Jul 21, 2021
Copy link
Contributor

@samrocksc samrocksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good and thorough. I'm assuming the reason we're not bumping patch is that this is not releasing any functionality?

@@ -13,37 +13,27 @@ jobs:

strategy:
matrix:
node-version: [12.x]
node-version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a request, but this made me wonder if we have any 10.x services using this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope not, it's no longer supported

@rohit-gohri
Copy link
Member Author

good and thorough. I'm assuming the reason we're not bumping patch is that this is not releasing any functionality?

Correct. I'm trying to include the Changelog.md file in the typedoc but no luck so far. Any ideas?

@ishan123456789
Copy link
Contributor

ishan123456789 commented Jul 21, 2021

Correct. I'm trying to include the Changelog.md file in the typedoc but no luck so far. Any ideas?

Might be due to some gitignore * mentioning
You can try to add !Changelog.md to force it to pick it up

ishan123456789
ishan123456789 previously approved these changes Jul 21, 2021
@rohit-gohri rohit-gohri dismissed stale reviews from ishan123456789 and samrocksc via fdfa214 July 21, 2021 10:36
@@ -7,9 +7,10 @@

This package contains a lightweight framework and subscription server for [Google Pub/Sub](https://cloud.google.com/pubsub). It was created to speed up development time and it provides a common foundation for building event driven applications. It lets developers define topics and subscriptions simply and declaratively, while additionally offering a simple subscription server to run all of a project's subscription handlers.

Docs: <https://deliveryhero.github.io/hfc-pubsub/>
- [Docs](https://deliveryhero.github.io/hfc-pubsub/)
- [Changelog](https://deliveryhero.github.io/hfc-pubsub/interfaces/changelog/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@samrocksc samrocksc self-requested a review July 21, 2021 10:41
@rohit-gohri rohit-gohri merged commit b0678c0 into main Jul 21, 2021
@rohit-gohri rohit-gohri deleted the chore/PUB-44-changesets branch July 21, 2021 12:52
@github-actions github-actions bot mentioned this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants